Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the tests run faster by reducing PREC #1500

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

certik
Copy link
Contributor

@certik certik commented Feb 7, 2019

This speeds up the test_series_generic test in Debug mode from 1.09s to 0.83s.
Before:

$ ctest -R test_series_generic
Test project /home/certik/repos/symengine
    Start 6: test_series_generic
1/1 Test #6: test_series_generic ..............   Passed    1.09 sec

100% tests passed, 0 tests failed out of 1

Total Test time (real) =   1.10 sec

After:

$ ctest -R test_series_generic
Test project /home/certik/repos/symengine
    Start 6: test_series_generic
1/1 Test #6: test_series_generic ..............   Passed    0.83 sec

100% tests passed, 0 tests failed out of 1

Total Test time (real) =   0.84 sec

This helps with #1012, but still not fixed.

@certik
Copy link
Contributor Author

certik commented Feb 18, 2019

I rebased on top of the latest master. The tests should pass now.

@certik certik requested a review from isuruf March 28, 2019 20:00
@isuruf
Copy link
Member

isuruf commented Apr 11, 2019

I don't think the test time is a big issue. Were large prec used to test some specific code paths?

@certik
Copy link
Contributor Author

certik commented Apr 11, 2019

Were large prec used to test some specific code paths?

That's what I am not sure --- it doesn't seem so. And if it doesn't test anything useful, I would argue the test should be as fast as possible. As we will keep adding more tests in the future, every bit counts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants