poly file name changes + making symengine mpolys inherit from a base class #1255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srajangarg
commented
May 10, 2017
| } | ||
| } | ||
|
|
||
| static set_basic get_translated_container(Container &x, Container &y, |
There was a problem hiding this comment.
Was moved inside the class, as different classes can have different get_translated_container methods, which serve different purposes. Hence the add/sub/mul/div functions use that particular class's get_translated method, and remain the same for all classes. (just how +, -, x, / were overloaded for univariate poly classes and implemented commonly for all classes)
|
@isuruf can we merge? I'm unable to write multivariate piranha polynomials at the moment. Will do it another PR. |
|
That looks good to me. @isuruf any objections? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this base class can be used to inherit the piranha mpoly class
I think that the file names are much more well defined now.