Merge pull request #1564 from isuruf/coeff2

Fix coeff(x+1, x, 0)
symengine · Jul 13, 2019 · f7e253f · f7e253f
2 parents 9e4c0bb + c853166
commit f7e253f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/symengine/tests/basic/test_basic.cpp b/symengine/tests/basic/test_basic.cpp
@@ -988,6 +988,7 @@ TEST_CASE("coeff: Basic", "[basic]")
     REQUIRE(eq(*coeff(*r5, *x, *integer(0)), *pow(y, integer(3))));
 
     REQUIRE(eq(*coeff(*r6, *x, *integer(0)), *y));
+    REQUIRE(eq(*coeff(*add(r6, one), *x, *integer(0)), *add(y, one)));
 }
 
 TEST_CASE("free_symbols: Basic", "[basic]")

diff --git a/symengine/visitor.h b/symengine/visitor.h
@@ -149,6 +149,9 @@ class CoeffVisitor : public BaseVisitor<CoeffVisitor, StopVisitor>
                 Add::coef_dict_add_term(outArg(coef), dict, p.second, coeff_);
             }
         }
+        if (eq(*zero, *n_)) {
+            iaddnum(outArg(coef), x.get_coef());
+        }
         coeff_ = Add::from_dict(coef, std::move(dict));
     }