Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Acquiring GIL in pywrapper.cpp #153

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Acquiring GIL in pywrapper.cpp #153

wants to merge 1 commit into from

Conversation

ShikharJ
Copy link
Member

Relevant: #61

@ShikharJ
Copy link
Member Author

@isuruf @Sumith1896 I'm not sure whether these are the expected changes. Can you please take a look and suggest improvements?

@ShikharJ
Copy link
Member Author

Ping @isuruf @Sumith1896 .

isuruf
isuruf reviewed Jun 14, 2017
View reviewed changes
symengine/lib/pywrapper.cpp Outdated
@@ -7,6 +7,12 @@

namespace SymEngine {

#if PY_MAJOR_VERSION >= 3
if (!PyGILState_Check()) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can run code only inside a function. This is outside any function.

@ShikharJ
Copy link
Member Author

ShikharJ commented Aug 7, 2017

@isuruf Any suggestion what can be done here?

@ShikharJ
Copy link
Member Author

ShikharJ commented Sep 2, 2017

@isuruf I'd like to get all my PRs merged, as soon as possible. Can you tell me if anything can be done here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isuruf isuruf isuruf left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ShikharJ @isuruf