Using biocmanager for flowcore and biobase #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+12
to
+16
| # BiocManager is used to provide compatibility for flowCore for R version 3.6 and above. | ||
| if (!requireNamespace("BiocManager", quietly = TRUE)) | ||
| install.packages("BiocManager") | ||
| BiocManager::install("flowCore") | ||
| BiocManager::install("Biobase") |
There was a problem hiding this comment.
As far as I can see, this change might break backwards-compatibility with older versions of R.
@tomashhurst Would you accept a pull request with an if statement that checks for the R version and then either uses the current code (R < 3.6) or the code @ghar1821 suggested for higher R versions?
Chris
There was a problem hiding this comment.
That certainly would! There might be some issues with the Bioconductor end of things, but we can certainly try that out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For R version 3.6 and above, you cannot install flowcore and biobase using the normal way (you need biocmanager). I've updated this and changed a couple of typo in comments.