-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Intersphinx: support external/external+ roles #514
base: develop
Are you sure you want to change the base?
Conversation
Thanks for looking at this!
I think it's fine to keep everything in
Maybe we should have both options, it definitely makes sense to be able to do this dynamically in the intersphinx case but I think it also makes sense to just call |
for more information, see https://pre-commit.ci
… into add-external-role-support
Hey, just thought I'd check in and see if you needed anything from me on this? I hope you haven't been waiting on me without me realising! Also, would you be ok with me merging #484 ahead of this? Happy to help realign this branch if needed 😄 |
@alcarney please go ahead, don't wait for me! I've been busy, so I may be a little slow to complete this PR, the only thing I'm missing is adding tests. Haven't written documentation lately, but I'm using this branch just to make sure nothing breaks. |
No worries, just wanted to make sure I wasn't going to pull the rug out from under you :) |
:foo:bar:baz:
roles (roles with more than two:
):external:doc:
==:doc:
. Of course, this should already be possible withadd_documentation
, but having it in RoleLanguageFeature encapsulates all the logic there.Closes #464