Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Article and comment delete #150

Merged
merged 5 commits into from Nov 30, 2019
Merged

Article and comment delete #150

merged 5 commits into from Nov 30, 2019

Conversation

lightb0x
Copy link
Contributor

  • 백엔드 delete 구현 (DELETE가 아닌 PUT에 구현함, DELETE로 하면 인풋을 두 개 받지못함)
  • 프론트엔드 delete 구현
  • 테스트코드 수정/작성

ulgal
ulgal suggested changes Nov 30, 2019
View reviewed changes
frontend/src/store/actions/comment.js Outdated Show resolved Hide resolved
@lightb0x lightb0x requested a review from ulgal November 30, 2019 10:12
@ulgal
Copy link
Contributor

ulgal commented Nov 30, 2019

혹시 pylint ypaf랑 black중에 뭐 쓰시나요? 저는 black쓰는데 제 세팅하고 약간 다른 것 같아서요.

@lightb0x
Copy link
Contributor Author

vscode 기본세팅으로 하고있습니다

@lightb0x lightb0x merged commit 1e3929d into master Nov 30, 2019
@lightb0x lightb0x deleted the article-and-d branch November 30, 2019 11:53
@lightb0x lightb0x mentioned this pull request Nov 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulgal ulgal ulgal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lightb0x @ulgal