Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update g_partition.py #77

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update g_partition.py #77

wants to merge 1 commit into from

Conversation

Lamply
Copy link

@Lamply Lamply commented Oct 29, 2020

bug fix

nisargshah1999
nisargshah1999 approved these changes Mar 4, 2021
View reviewed changes
Copy link

@nisargshah1999 nisargshah1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is true and working

@ucalyptus2
Copy link

@Lamply @nisargshah1999 the 3 txt files are still empty even after running g_partition from @Lamply's fix.

image

@duguyue100
Copy link

@Lamply @nisargshah1999 the 3 txt files are still empty even after running g_partition from @Lamply's fix.

image

Even the original g_partition.py forget to write contents in the text files. But given you have all the train, val, and test folders, it's easy to populate these lists by walking through the folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nisargshah1999 nisargshah1999 nisargshah1999 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Lamply @ucalyptus2 @duguyue100 @nisargshah1999