Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -n switch to grep command #1392

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

jsteyn
Copy link
Contributor

@jsteyn jsteyn commented May 9, 2023

Without the -n switch on grep to include line numbers on the result, the cut -d : -f 2 of the script serves no purpose

Without the -n switch on grep to include line numbers on the result, the `cut -d : -f 2` of the script serves no purpose
@github-actions
Copy link

github-actions bot commented May 9, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/swcarpentry/shell-novice/compare/md-outputs..md-outputs-PR-1392

The following changes were observed in the rendered markdown documents:

 07-find.md | 2 +-
 md5sum.txt | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-05-16 11:17:53 +0000

github-actions bot pushed a commit that referenced this pull request May 16, 2023
@bkmgit
Copy link
Contributor

bkmgit commented May 16, 2023

Thanks for the pull request. It does not seem to match the output shown in https://github.com/swcarpentry/shell-novice/blob/main/episodes/07-find.md?plain=1#L321-L324 the -n gives line numbers in which the text string is found. Maybe something else is needed? If so, one would also need to update https://github.com/swcarpentry/shell-novice/blob/main/episodes/07-find.md?plain=1#L350-L352

@deppen8 deppen8 added the status:waiting for response Waiting for Contributor to respond to maintainers' comments or update PR label May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:waiting for response Waiting for Contributor to respond to maintainers' comments or update PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants