Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded div titles #620

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove hardcoded div titles #620

wants to merge 2 commits into from

Conversation

Bisaloo
Copy link
Member

@Bisaloo Bisaloo commented Apr 19, 2024

We don't need to hardcode the div titles as sandpaper will add them on its own.

Hardcoding them also make it more difficult to centrally make updates from sandpaper (e.g., translations). At the moment for examples, the div titled "solutions" or "pre-requisites" (note the extra "s") can be translated by sandpaper.

@Bisaloo Bisaloo requested a review from a team April 19, 2024 08:55
Copy link

github-actions bot commented Apr 19, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/swcarpentry/r-novice-inflammation/compare/md-outputs..md-outputs-PR-620

The following changes were observed in the rendered markdown documents:

 01-starting-with-data.md    | 22 -----------
 02-func-R.md                | 12 ------
 03-loops-R.md               |  8 ----
 04-cond.md                  |  8 ----
 05-cmdline.md               | 12 ------
 06-best-practices-R.md      |  2 -
 10-supp-addressing-data.md  | 12 ------
 11-supp-read-write-csv.md   |  4 --
 12-supp-factors.md          | 16 +++-----
 13-supp-data-structures.md  | 12 ------
 data/car-speeds-cleaned.csv | 94 ---------------------------------------------
 index.md                    |  5 ---
 md5sum.txt                  | 22 +++++------
 13 files changed, 16 insertions(+), 213 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-04-19 08:57:40 +0000

github-actions bot pushed a commit that referenced this pull request Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant