Incorrect number of commits before head for shown output. #989
Conversation
As I followed along, the $ git diff HEAD~3 is back one commit further than my history. It is possible if a previous aside is followed that this might not generate an error about that version not existing, however, the output shown indicates no such commit. So the command is inconsistent with the output shown. A simple fix is to replace the "3" with a "2"
🆗 Pre-flight checks passed 😃This pull request has been checked and contains no modified workflow files, spoofing, or invalid commits. It should be safe to Approve and Run the workflows that need maintainer approval. |
|
@cgeroux will you verify which commits you entered ( |
|
I only have three: `$ git log commit 745ca038a4d6adc760095b46f40004730efcf0a5 commit 2ea1847fc9f697d706b571f32337313aece2ef55 ` |
|
If I did an extra commit, as mentioned in the "Directories" callout:
I would then have four. |
|
Another possibility to have 4 commits would be from the commit in the "COMMITTING MULTIPLE FILES" exercise.
|
This pull request Closes #963
As I followed along, the
git diff HEAD~3on episode 5 references a commit back one commit further than my history. This leads to the outputfatal: ambiguous argument 'HEAD~3': unknown revision or path not in the working tree..It is possible if a previous aside (the directories callout) is followed that this will not generate
unknown revisionissue. With this change with the directories callout skipped it will produce output that is consistent with that shown in the lesson. If the directories callout is followed, it will produce inconsistent output, however, it will not produce the "fatal" error as it does now in the situation where the "directories" callout isn't followed.A competing solution would be to make the "directories" callout not a callout, but part of the flow of the workshop. However, in general it does seem to me that the "directories" callout really should be a callout and isn't critical to the overall flow of the lesson.