Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to new private email pattern from GitHub, explain where to fin… #987

Merged
merged 2 commits into from
May 28, 2024

Conversation

BalthasarSchachtner
Copy link
Contributor

…d the no-reply mail.

When going through the episode setup, I found a bit confusing that there is written

If you elect to use a private email address with GitHub, then use that same email address for the user.email value [...]

With the example after this part of the sentence it becomes clear what is meant, but I might be inclined to put my private mail there and expose it.
Next I saw, that the pattern for these no-reply mails seems to have changed in 2017 and now has the form ID+USERNAME@users.noreply.github.com: https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/setting-your-commit-email-address#about-commit-email-addresses

I tried to address both of these points in this pull request. Due to the ID in the no-reply email, I think it now needs to be looked up and cannot be formed from the user name, that's why I included the link, let me know if this works for you.

Copy link

github-actions bot commented Apr 8, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/swcarpentry/git-novice/compare/md-outputs..md-outputs-PR-987

The following changes were observed in the rendered markdown documents:

 02-setup.md | 2 +-
 md5sum.txt  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-05-02 07:45:01 +0000

@martinosorb
Copy link
Contributor

Thanks for the PR, I agree that the phrasing was confusing. I only changed your comma to a full stop for grammatical nicety.
@kekoziar are you ok with merging?

github-actions bot pushed a commit that referenced this pull request May 2, 2024
@martinosorb martinosorb merged commit 3221e00 into swcarpentry:main May 28, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request May 28, 2024
Auto-generated via {sandpaper}
Source  : 3221e00
Branch  : main
Author  : Martino Sorbaro <martinosorb@users.noreply.github.com>
Time    : 2024-05-28 12:00:11 +0000
Message : Merge pull request #987 from BalthasarSchachtner/main

Update to new private email pattern from GitHub, explain where to fin…
github-actions bot pushed a commit that referenced this pull request May 28, 2024
Auto-generated via {sandpaper}
Source  : 73646d0
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-05-28 12:01:17 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 3221e00
Branch  : main
Author  : Martino Sorbaro <martinosorb@users.noreply.github.com>
Time    : 2024-05-28 12:00:11 +0000
Message : Merge pull request #987 from BalthasarSchachtner/main

Update to new private email pattern from GitHub, explain where to fin…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants