Update to new private email pattern from GitHub, explain where to fin… #987
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…d the no-reply mail.
When going through the episode setup, I found a bit confusing that there is written
With the example after this part of the sentence it becomes clear what is meant, but I might be inclined to put my private mail there and expose it.
Next I saw, that the pattern for these no-reply mails seems to have changed in 2017 and now has the form
ID+USERNAME@users.noreply.github.com
: https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/setting-your-commit-email-address#about-commit-email-addressesI tried to address both of these points in this pull request. Due to the
ID
in the no-reply email, I think it now needs to be looked up and cannot be formed from the user name, that's why I included the link, let me know if this works for you.