-
-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stress the importance of git status
(#685)
#980
base: main
Are you sure you want to change the base?
Conversation
🆗 Pre-flight checks passed 😃This pull request has been checked and contains no modified workflow files, spoofing, or invalid commits. It should be safe to Approve and Run the workflows that need maintainer approval. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure it's the same as ls
. Maybe, instead of It's the Git equivalent of listing a directory in a shell. it can be "It tells us the status of our project, and better, a list of changes in the project and options on how to resolve those changes"
Ok, I see it's a bit imprecise to say the Git equivalent of ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it. Thanks for the quick change. I tagged another maintainer for review.
I like the idea of adding more emphasis on this command at that point. However, I think the phrasing is a bit off:
I would suggest something like We can now start using one of the most important git commands, which is particularly helpful to beginners. |
Closes #685
Based on the discussion in the issue, I'm limiting the changes to just giving a bit of emphasis on the moment the
git status
command is first used.