Big PR 1/7: UX basics part 1 #170
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…) and record them to the undo history
…iables for long edit_mode expressions, add grid_is_square() helper
… (only normal square puzzles for now)
…u mode, and make shift-arrow work too
… certain submodes for now)
…mode, and make the logic less restrictive on what types of cells this works for
…ht want to clear the selection in some cases but for now having more cells selected when changing modes etc is much better than it clearing all the time
… clicks on a selected cell and drags
|
Thank you. I will start the review soon after I settle down from my traveling. Can you please change the merging branch to dev branch instead of master. @zwegner |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Swaroop! I've been organizing the big amount of changes I have to be grouped into smaller logical chunks, and here's the first: starting off with some refactoring that is used in many places throughout all my changes, followed by a bunch of small interface tweaks to improve the user experience, mostly dealing with selection behavior.
Happy to answer any questions you might have about the changes. I've also made more branches for my intended future PRs after this one if you're curious to look ahead.