Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: support clearing reports and CLIs in SBOM and in new command "bom downloadattachments" #33

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

gernot-h
Copy link
Collaborator

First draft for #24

@gernot-h gernot-h marked this pull request as draft July 18, 2023 18:17
@gernot-h gernot-h force-pushed the feat-bom-attachmentinfo branch 2 times, most recently from b1a5689 to 2ee751e Compare July 18, 2023 18:45
@gernot-h
Copy link
Collaborator Author

gernot-h commented Jul 31, 2023

@tngraf, while this is far from complete, I would like to ask for your opinion about storing the attachment information in the SBOM.

For now, project createbom adds external references for the attachments like these:

        {
          "url": "CLIXML_libxml2_2.9.4+dfsg1-2.2+deb9u3-debian-combined.zip_2020-11-09_12_40_19.xml",
          "comment": "component license information (local copy), sw360Id: 0546f2...",
          "type": "other",
          "hashes": [
            {
              "alg": "SHA-1",
              "content": "b272c58e300713207fc963ea5a792bc00835f730"
            }
          ]
        },
        {
          "url": "libxml2_2.9.4+dfsg1-2.2+deb9u3-debian-combined.zip_clearing_report_Mon_Nov_09_11_2020_12_22_58.docx",
          "comment": "clearing report (local copy), sw360Id: 0546f3...",
          "type": "other",
          "hashes": [
            {
              "alg": "SHA-1",
              "content": "6de0b76d42c3ef9f8aa7254bdb868625385df30f"
            }
          ]
        }

I think it's a good idea to store the sw360Id of the attachments in the SBOM so I don't need to search for the file for later bom downloadattachments. I'm however unsure about how to store it. As first try, I add it to the comment string per external reference, see example above.

And the same problem applies to later download step, where I'd also like to store the per-attachment information like createdBy, checkedBy, createdOn etc. so I can filter and document them for later upload steps.

In project getlicenseinfo you store them in a proprietary JSON format like this:

    {
      "ComponentName": "aufs-tools 4.1+20161219",
      "CliFile": "folder/CLIXML_aufs-tools_1:4.1+20161219-1-debian-combined.tar.bz2_2022-05-12_10:43:09.xml",
      "CreatedBy": "user@siemens.com",
      "CreatedOn": "2022-05-12",
      "CheckedBy": "admin@siemens.com",
      "CheckedTeam": "AA",
      "CheckStatus": "ACCEPTED"
    }

This however won't work if I have multiple CLI and report attachments.

So I can think about the following options:

  • create a separate output file with another proprietary JSON format to hold all attachment metadata
  • add all the metadata to the SBOM. As far as I can see, you cannot add custom properties to external references, so I would need to think about some way to store them either in comments there (ugly!) or in some flat variant in the component's custom properties

All the options sound a bit ugly to me... :)

@gernot-h gernot-h force-pushed the feat-bom-attachmentinfo branch 4 times, most recently from e2e1d69 to 0621d97 Compare August 7, 2023 15:50
@gernot-h gernot-h force-pushed the feat-bom-attachmentinfo branch 2 times, most recently from f8c7a50 to d4e70ef Compare August 9, 2023 15:18
@gernot-h gernot-h changed the title Draft: feat(project CreateBom): add clearing reports and CLIs Draft: support clearing reports and CLIs in SBOM and in new command "bom downloadattachments" Aug 10, 2023
@gernot-h gernot-h force-pushed the feat-bom-attachmentinfo branch 2 times, most recently from 140f122 to e8ce557 Compare August 19, 2023 05:47
@gernot-h gernot-h force-pushed the feat-bom-attachmentinfo branch 3 times, most recently from 038fd52 to 49f551a Compare August 22, 2023 08:14
@gernot-h
Copy link
Collaborator Author

I integrated the current implementation of "project createbom" and "bom downloadattachments" into some internal attachment import scripts (https://code.siemens.com/linux/distro-clearing/debian) where it seems to work well.

So I consider this part as "implemented" (tm), but I'm still unsure about the way how to store additional data for the attachments. I now went for creating a proprietary JSON "control file" with similar syntax to the output of "project getlicenseinfo" as described above.

Another possibility would be to create some kind of "extended BOM" adding the clearing reports and CLI files as own CycloneDX components of type "file" and linking to them using the bom-ref mechanism, inspired by the discussion in CycloneDX/specification#135 (comment). Then I could add the interesting data as CycloneDX properties for these components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant