Project getlicenseinfo help and option improvement #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace generic parameter descriptions by the specific semantics in context of "project GetLicenseInfo".
There's no need to require "-o", we can simply skip writing of this output file. I removed the test case for it as I had no clever idea what to verify if "-o" was not given...
|
I agree that the help documentation and the error message could have been better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As preparation for #24, I tried to understand exact usage of "project getlicenseinfo" and was a bit confused about the idea of "-o", so I tried to make it clearer. Also, the error message when not specifying "-o" confused me, so I removed it completely and made it optional instead. :)