Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: broadcast target for rx #308

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

landswellsong
Copy link

Hi,
Made this change for myself, but may be useful elsewhere. Allows to specify broadcast addresses for connect:// at rx side. Ideally we may want to check if the address is indeed a broadcast, but mavlink-router doesn't bother to do that so I'm not sure. Maybe it will fail if running as unprivileged user though.

@svpcom
Copy link
Owner

svpcom commented Oct 12, 2023

@landswellsong Why not use multicast 224.0.0.1 address instead of broadcast? It doesn't require any additional permissions

@landswellsong
Copy link
Author

@svpcom great alternative, didn't think of that. But I have options of some SW on an android tablet that's not aware of multicast, I'm not sure it can join the multicast group normally without too much rewrite.

How about I add broadcasting as an option so it's only set if you explicitly mention it in the config?

@svpcom
Copy link
Owner

svpcom commented Oct 12, 2023

@landswellsong 224.0.0.1 multicast group is "local network" group and all hosts are members of it by default. It already used in wfb-ng video broadcasting example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants