fix: map optionalReplacementSpan for typescript-language-server #2257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2251 For typescript plugin
The reason is that
ts.CompletionInfo.optionalReplacementSpanis still generated position, and the typescript-language-server used it to create TextEdit, but the position doesn't exist. Neovim probably filters it out because it is invalid. VSCode doesn't usets.CompletionInfo.optionalReplacementSpan, so we never map it.https://github.com/typescript-language-server/typescript-language-server/blob/80ef6149cd64b9859e402adb1ca3e7c410ab52b5/src/lsp-server.ts#L529
https://github.com/typescript-language-server/typescript-language-server/blob/80ef6149cd64b9859e402adb1ca3e7c410ab52b5/src/completion.ts#L154