Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix expression to remove type-check compiler error in Xcode 12 #53

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mushthak
Copy link

Hi There,

Created this PR to fix the issue(#52 ) causing type-check compiler error in Xcode 12.

Thanks for considering it!

@hho114
Copy link

hho114 commented Sep 28, 2020

You can assign the owner as a reviewer to take a look at your PR.

@mushthak
Copy link
Author

mushthak commented Oct 5, 2020

You can assign the owner as a reviewer to take a look at your PR.

There is no edit option in the reviewers section. I will add a comment down here.
Hi @suzuki-0000 , awaiting review for this PR.

@magnett
Copy link

magnett commented Dec 11, 2020

@mushthak it still doesn't compile using Xcode 12.2
error in CountdownLabel.swift, line 36 : Using '!' is not allowed here; perhaps '?' was intended?

@mushthak
Copy link
Author

@magnett, For me it is a warning and no issue with compilation or running.

Screen Shot 2020-12-11 at 3 19 06 PM

@magnett
Copy link

magnett commented Dec 11, 2020

You probably have the, iOS Deployment Target < 13.0 , that's why you get a warning instead of an error

@Isuru-Nanayakkara
Copy link

@mushthak it still doesn't compile using Xcode 12.2
error in CountdownLabel.swift, line 36 : Using '!' is not allowed here; perhaps '?' was intended?

Yep, I'm getting this error too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants