Remove frames in PixelDataInfo if the frame channel option is used #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suyashkumar
reviewed
Nov 6, 2023
Comment on lines
+259
to
261
| } else { | ||
| image.Frames = append(image.Frames, &f) | ||
| } |
There was a problem hiding this comment.
I suppose this is also an API change that means the PixelDataInfo returned from Parse will not have frames populated if the framechannel option is used? This might be ok, but is a meaningful change I'll think about a little.
luongthanhlam
force-pushed
the
reduce-allocation-per-channel
branch
from
98a517c
to
5006dd8
Compare
luongthanhlam
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove frames in PixelDataInfo if the frame channel option is used