Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Image Search Section #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ghost
Copy link

@ghost ghost commented Feb 8, 2017

Added image search section to main page. Closed the following issue:
#3

Add image search section to main page
@ghost ghost self-assigned this Feb 8, 2017
@ghost
Copy link
Author

ghost commented Feb 8, 2017

Any changes needed for the main image section?

@hlkessner
Copy link
Collaborator

We could add a preview section where users could see some images to entice them to explore more.

Copy link
Collaborator

@lariosw lariosw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job creating the image galleries section. I think the only change that I would suggest for the next step on this task would be adding a photo of something below the h2 title to visually help the user locate this section quickly. I think for now these changes are sufficient and it can be pushed.

Copy link
Collaborator

@lariosw lariosw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only additional thing I would change before merging would be from galleries to gallery since it is one gallery or archive to keep that consistent. Also as I commented before making this added change I would add a photo to help the user easily identify this section. Great work!

@@ -4,7 +4,9 @@
Author's custom styles
========================================================================== */


#image-galleries .btn {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#image-gallery

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would make the change to image-gallery instead of galleries since it is a singular gallery or archive.

<h2>Heading</h2>
<p>Donec sed odio dui. Cras justo odio, dapibus ac facilisis in, egestas eget quam. Vestibulum id ligula porta felis euismod semper. Fusce dapibus, tellus ac cursus commodo, tortor mauris condimentum nibh, ut fermentum massa justo sit amet risus.</p>
<p><a class="btn btn-default" href="#" role="button">View details &raquo;</a></p>
<div id="image-galleries" class="col-md-4">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<div id="image-gallery" class="col-md-4">

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants