-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Xxxx #12
base: master
Are you sure you want to change the base?
Conversation
index.html line 31. This is not working, the header image is not at the top and it is not “fixed”. |
This space was bumping the header image down.
I removed body padding.
I fixed a few of the spacing issues with the images in main.css and index.html. moving the header image below nav bar might look cleaner. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See suggested commits that I added to tighten some of the spacing to align images to nav.
<p class="browserupgrade">You are using an <strong>outdated</strong> browser. Please <a href="http://browsehappy.com/">upgrade your browser</a> to improve your experience.</p> | ||
<![endif]--> | ||
<nav class="navbar navbar-inverse navbar-fixed-top" role="navigation"> | ||
|
||
<!-- suggest moving image below nav bar. --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. The navbar should remain at the top of the page. I have no preference, fixed or floating.
<img src="the-poetry-cafeHEADER.jpg" alt="Header" width="100%"> | ||
</div> | ||
|
||
<nav class="navbar navbar-inverse navbar-fixed-1000px" role="navigation"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would recomment adding a .navbar-fixed-top to the container to fix it to the top of the page. I think this looks best visually. The body padding would not need to be changed to accommodate.
I would advocate to merge this pull request and get the structure of the page in place. Then it would be easier to workaround some of the header issues. |
I put in a header image and background image.
I moved the nav bar to below the header image.
I changed the opacity of jumbotron and added backgrounds to the three headings.