Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(bpfassets): Refactor to reduce the API exposed by bpfassets #1413

Merged
merged 3 commits into from
May 15, 2024

Commits on May 14, 2024

  1. chore(bpf): Don't re-export constants

    These constants are available in the config package already and do not
    need to be re-exported under a different name.
    
    Signed-off-by: Dave Tucker <dave@dtucker.co.uk>
    dave-tucker committed May 14, 2024
    Configuration menu
    Copy the full SHA
    ff9fa67 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. chore(bpf): Remove global variables from pkg/bpfassets

    This reduces the API exposed by the pkg/bpfassets and
    also makes it easier to test.
    
    Signed-off-by: Dave Tucker <dave@dtucker.co.uk>
    dave-tucker committed May 15, 2024
    Configuration menu
    Copy the full SHA
    cd70136 View commit details
    Browse the repository at this point in the history
  2. chore(Makefile): Fix test run control

    Remove the verbose test targets. You can enable this
    with make VERBOSE=1 test.
    
    Ensure e2e tests aren't run in the normal test target
    as they will fail.
    
    Skip bpfassets tests as they need sudo.
    
    Compile bpfassets tests to a tmpdir and then run them.
    
    Fix assertions in the bpfassets test to skip cpuFreq
    given that this isn't populated, and to add more
    assertions in the data that comes from `processes`.
    
    Split test run into unit-test, bpf-test and bench
    targets.
    
    Signed-off-by: Dave Tucker <dave@dtucker.co.uk>
    dave-tucker committed May 15, 2024
    Configuration menu
    Copy the full SHA
    1630918 View commit details
    Browse the repository at this point in the history