feat: add codesandbox example #867
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Overview
<!--
A clear and concise description of what this pr is about.
-->
## PR Checklist
- [ ] I did below actions if need
1. I read the [Contributing
Guide](https://github.com/suspensive/react/blob/main/CONTRIBUTING.md)
2. I added documents and tests.
…store (#631) fix #183 # Overview <!-- A clear and concise description of what this pr is about. --> I remove target react v16, v17, unnecessary use-sync-external-store ## PR Checklist - [x] I did below actions if need 1. I read the [Contributing Guide](https://github.com/suspensive/react/blob/main/CONTRIBUTING.md) 2. I added documents and tests.
fix #529 # Overview <!-- A clear and concise description of what this pr is about. --> ## PR Checklist - [x] I did below actions if need 1. I read the [Contributing Guide](https://github.com/suspensive/react/blob/main/CONTRIBUTING.md) 2. I added documents and tests.
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to beta, this PR will be updated.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ `beta` is currently in **pre mode** so this branch has prereleases rather than normal releases. If you want to exit prereleases, run `changeset pre exit` on `beta`.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ # Releases ## @suspensive/react@2.0.0-beta.0 ### Major Changes - ea1c4ed: feat(react): rename Suspensive defaultOptions -> defaultProps - 78f5bd4: feat(react, react-query): remove deprecated apis - 837ed18: feat(\*): remove target react v16, v17 ## @suspensive/react-query@2.0.0-beta.0 ### Major Changes - 78f5bd4: feat(react, react-query): remove deprecated apis - 837ed18: feat(\*): remove target react v16, v17 ### Patch Changes - Updated dependencies [ea1c4ed] - Updated dependencies [78f5bd4] - Updated dependencies [837ed18] - @suspensive/react@2.0.0-beta.0 ## @suspensive/react-await@0.0.16-beta.0 ### Patch Changes - 837ed18: feat(\*): remove target react v16, v17 ## @suspensive/react-image@0.0.10-beta.0 ### Patch Changes - 837ed18: feat(\*): remove target react v16, v17 ## @suspensive/visualization@0.0.24-beta.0 ### Patch Changes - Updated dependencies [ea1c4ed] - Updated dependencies [78f5bd4] - Updated dependencies [837ed18] - @suspensive/react@2.0.0-beta.0 - @suspensive/react-query@2.0.0-beta.0 - @suspensive/react-await@0.0.16-beta.0 - @suspensive/react-image@0.0.10-beta.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…on correctly like @tanstack/react-query v5 (#401) fix #253 # Overview <!-- A clear and concise description of what this pr is about. --> ## PR Checklist - [x] I did below actions if need 1. I read the [Contributing Guide](https://github.com/suspensive/react/blob/main/CONTRIBUTING.md) 2. I added documents and tests.
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to beta, this PR will be updated.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ `beta` is currently in **pre mode** so this branch has prereleases rather than normal releases. If you want to exit prereleases, run `changeset pre exit` on `beta`.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ # Releases ## @suspensive/react-query@2.0.0-beta.1 ### Major Changes - d06e883: fix(react-query): @suspensive/react-query v2's all naming convention correctly like @tanstack/react-query v5 ### Patch Changes - @suspensive/react@2.0.0-beta.1 ## @suspensive/react@2.0.0-beta.1 ## @suspensive/visualization@0.0.24-beta.1 ### Patch Changes - Updated dependencies [d06e883] - @suspensive/react-query@2.0.0-beta.1 - @suspensive/react@2.0.0-beta.1 - @suspensive/react-await@0.0.16-beta.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
# Overview
<!--
A clear and concise description of what this pr is about.
-->
I remove ErrorBoundaryGroup.Reset
## PR Checklist
- [x] I did below actions if need
1. I read the [Contributing
Guide](https://github.com/suspensive/react/blob/main/CONTRIBUTING.md)
2. I added documents and tests.
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to beta, this PR will be updated.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ `beta` is currently in **pre mode** so this branch has prereleases rather than normal releases. If you want to exit prereleases, run `changeset pre exit` on `beta`.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ # Releases ## @suspensive/react@2.0.0-beta.2 ### Major Changes - 6a3f6f4: feat(react): remove ErrorBoundaryGroup.Reset ## @suspensive/react-query@2.0.0-beta.2 ### Patch Changes - Updated dependencies [6a3f6f4] - @suspensive/react@2.0.0-beta.2 ## @suspensive/visualization@0.0.24-beta.2 ### Patch Changes - Updated dependencies [6a3f6f4] - @suspensive/react@2.0.0-beta.2 - @suspensive/react-await@0.0.16-beta.0 - @suspensive/react-query@2.0.0-beta.2 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to beta, this PR will be updated.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ `beta` is currently in **pre mode** so this branch has prereleases rather than normal releases. If you want to exit prereleases, run `changeset pre exit` on `beta`.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ # Releases ## @suspensive/react@2.0.0-beta.3 ### Major Changes - [#629](#629) [`73c0cc7`](73c0cc7) Thanks [@manudeli](https://github.com/manudeli)! - fix(react): add getServerSnapShot in syncDevMode ## @suspensive/react-query@2.0.0-beta.3 ### Patch Changes - Updated dependencies \[[`73c0cc7`](73c0cc7)]: - @suspensive/react@2.0.0-beta.3 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## beta #867 +/- ##
=======================================
Coverage 83.87% 83.87%
=======================================
Files 31 31
Lines 428 428
Branches 98 97 -1
=======================================
Hits 359 359
Misses 61 61
Partials 8 8
|
2 tasks
|
toss/slash#191 (comment) Check this out please |
|
Rebase is needed before doing this (#867 (comment)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
closed #7
Points to discuss
theme
I have selected the theme as
atom dark.Attach a link to the page that lists the available themes: https://sandpack.codesandbox.io/docs/getting-started/themes
Sandpack Component abstraction
It's hard to use autocomplete in MDX because there is no type inference.
I had a choice between constraining the interface to only accept code, and leaving the interface open to modify whenever needed, and I chose the latter.
Once I get this PR review, I'll look for improvements, fix them, and apply them to all articles in bulk.
PR Checklist