astro-icon config update #51
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hi, Thanks for the PR, but the file changes seems to be extensive and unwanted. Could you please re-do it and only change what's necessary for this PR? Do not change any other files which is not required for this icon-change. You have a lot of them here: https://github.com/surjithctly/astroship/pull/51/files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I was checking out your astro template and when trying to change some icons, the website was crashing.
I don't know if it was me who wasn't figuring out how to change the icons properly (because i'm new to astro), but after updating the astro-icon version and setting up the configuration, i was able to make it work again!
I hope I've contributed with this small adjustment and thanks for the awesome template!