feat: add a "tap"-method to perform side effects #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lauhon
force-pushed
the
add-side-effects
branch
from
e418170
to
5e1e2cb
Compare
lauhon
force-pushed
the
add-side-effects
branch
from
5e1e2cb
to
372f1d9
Compare
lauhon
changed the title
|
Hey, @supermacro what do you think about this? |
supermacro
requested changes
Oct 30, 2023
| return new Err<T, E>(res.error) | ||
| } | ||
|
|
||
| await f(res.value) |
There was a problem hiding this comment.
What if the promise fails? Shouldn't this be wrapped in a try / catch? ResultAsync.fromPromise could also be used here, which requires a handler function in the event the promise fails.
There was a problem hiding this comment.
Good question @supermacro , I'm honestly not sure. Maybe that's a good indicator that I should add a test that covers that(?)
I pretty much copied the map implementation. The only difference is that instead of returning the result of the passed function, I execute the function and then return the previous value.
If I add a try-catch to the tap function, shouldn't I also add one to the map and mapErr functions? 🤔
| @@ -709,7 +762,7 @@ describe('ResultAsync', () => { | |||
| expect(mapAsyncFn).toHaveBeenCalledTimes(1) | |||
| }) | |||
|
|
|||
| it('Skips an error', async () => { | |||
| it('Skips an error when mapping an asynchronous value', async () => { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
created this to run side effects like logging.
Name "tap" is inspired by rxjs tap