Changed LinkAttribution to allow invalid (unchecked) URLs (Resolves #1927) #1943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@roughike please let me know if this covers what you need. |
|
@roughike - checking again on this. Can you let me know if this change provides what you need? |
|
@miguelcmedeiros @brian-superlist - Can one of you follow up with @roughike on this? |
roughike
approved these changes
May 8, 2024
matthew-carroll
added a commit
that referenced
this pull request
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed LinkAttribution to allow invalid (unchecked) URLs (Resolves #1927)
The
LinkAttribution'surlproperty is now aStringinstead of aUri, so thatLinkAttributions can hold invalid URLs.For easy
Uriaccess, I added auriproperty, which parses theurlwhen it's accessed. This is a convenience so that users don't have to explicitly parse aUriall over the place.FYI: The motivation for this change is that an existing document, possibly from another source, is parsed and loaded into
SuperEditor. This process fails for a document that happens to contain links for invalid URLs.