[SuperEditor][SuperReader] Adds tests editor's scrolling when present within parent scrollable #1733
+362
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rutvik110
added
area_supereditor
|
@rutvik110 this PR has been around for a while. Can you do something with it? |
This is currently blocked by #1798. Will be working on that issue before I can get this moving. |
|
@matthew-carroll Looking deeper into the issues blocking this PR, it's clear that we'll need to get the #1798 and #1734 fixed before I can move on with this PR. More importantly, #1734 as I believe it may be part of the problem within #1798, still need to do some investigation here. I think @angelosilvestre had some work done on the #1734 in the past, I'll try to take look into that and see what we can do here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[SuperEditor][SuperReader] Adds tests editor's scrolling when present within parent scrollable (Related #120)
This PR adds tests for locking down the behaviour for
SuperEditorandSuperReaderfor the following scenario:When scrolling within a parent scrollable, makes sure parent scrollable is scrolled after all of the scrollable content is consumed within editor when the user's hovering over editor.