Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening API for Cross-Origin Request #39

Merged
merged 1 commit into from Jan 22, 2018
Merged

Opening API for Cross-Origin Request #39

merged 1 commit into from Jan 22, 2018

Conversation

idantb101
Copy link
Contributor

so turns out, if I would like my API to be accessed I need to set the headers correctly.
this fix should do it.
reference axios/axios#853

Copy link
Contributor

@Amirk390 Amirk390 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👍

@idantb101
Copy link
Contributor Author

Can somebody please have a look @Karyum, @claireinez

@harrygfox harrygfox self-requested a review January 22, 2018 16:11
Copy link
Contributor

@harrygfox harrygfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🙌 🤞 🤷‍♀️

@harrygfox harrygfox merged commit c331410 into master Jan 22, 2018
@claireinez claireinez deleted the opening-api branch January 22, 2018 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants