-
Notifications
You must be signed in to change notification settings - Fork 732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add .bounds_ method to Stethoscope #6281
add .bounds_ method to Stethoscope #6281
Conversation
documentation update for the method .scope to define the location of scope window
documentation update for the method .scope to define the scope window location
update .scope method to locate scope window position
added variables to have a singleton plotTreeWindow and a singleton scopeWindowDefined
changed position argument in scope method to bounds
The position arguments for the server scope method and the function scope method are changed to bounds. And the server scope is changed so that it displays only one scope and works fine when users use manually assigned bounds and the default bound value of nil in succession.
has been modified to show only one boundary and to work fine when users are using manually assigned bounds and the default boundary value of nil, one after the other. Also, pressing m will change its size based on user-defined bounds, if any.
position argument for scope method is changed to bounds, so the documentation is updated
added bounds argument to the method `.plotTree`
documentation update for the added argument `bounds` for the method `.plotTree`
added point to define the server meter position.
documentation update for the added position argument for .meter method.
spaces within curly brackets are added
The behaviour of resizing has been corrected. It now retains the position as before if the new width and height do not exceed the screen boundary. If the new height exceeds the screen boundary, the vertical point is modified so that it does not exceed the screen boundary. If the new width exceeds the screen boundary, then the horizontal point is modified so that it does not exceed the screen boundary.
added the behaviour of change size if the new size exceeds the screen boundary.
The implementation of .scope has been simplified.
The implementation of .scope has been simplified.
added bounds for scope argument for Bus
bounds = nil in arg -> bounds
position = nil in arg -> position
…tethoscope.bounds)
Please let me know if this PR should be split again as follows:
|
I'm in favor of adding the The reason is that we found previously that setting geometry based on
So given there may be split views on this, the resizing behavior change could delay the other change you want to make |
Done! Now I see the benefit of following your and @jrsurge's advice! This PR is also the best for me, as I know at a glance what I have done here! |
Please add documentation for the added method. Note for the description of the argument that: For example the scope bounds can be set with: s.scope.bounds_(Rect(100, 200, 500, 600));
s.scope.bounds_([100, 200, 500, 600]);
s.scope.bounds_(Size(500, 600)); |
Done! Thanks for the instructions, and sorry for my clumsy process. A few days ago, I merged by clicking update on each of the outdated branches... So the histories are very dirty. In the future, I will do what you wrote on the wiki. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
an object with a setter should also have a getter.
METHOD:: bounds | ||
The position and size of the window. The position is relative to the bottom-left corner of the screen. | ||
argument:: | ||
A Rect, a Point interpreted link::Classes/Point#-asRect#.asRect:: or anything that responds to it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UsingPoint
perhaps isn't the best example since, although that's valid, specifying a Point implicitly sets the position to [0,0]
. I think omitting an example in the arg description is ok, since you provide examples below anyway.
Something like:
A link::Classes/Rect::, or any object responding to the link::Search#-asRect:: method.
(suggestion untested in the renderer)
As an aside I think Point:-asRect
is rather counterintuitive (a point is a position) compared to, say, Size:-asRect
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have done!
39802c6
Good point! I noticed the method documentation listed a return value, though there isn't yet actually a getter method. |
- setter bounds_ now has a message if the width is less than 264. - Added getter bounds.
I thought about it too! Thank you very much. I have done that. |
- Go to subsection Show - Correct the argument description - add about width change to the argument description - rearrange examples
change display text for link::Search#asRect::
This comment was marked as outdated.
This comment was marked as outdated.
@mtmccrea thanks!!! |
add .bounds_ method to Stethoscope.
Purpose and Motivation
This is a reopened PR: #6230
This PR
Stethoscope
,s.scope.bounds_(Rect(100, 200, 300, 100))
demo video:
https://www.dropbox.com/scl/fi/26952qepzu3iczj9bi0cq/s.bounds_-behaviour.mov?rlkey=suub8zyf6ujpksc7ugieggp02&dl=0
Types of changes
To-do list