Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve the conflict between SC-cube and text in the SC help Home with a typo correction in scdoc.css #6275

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

prko
Copy link
Contributor

@prko prko commented Apr 28, 2024

Purpose and Motivation

  1. This PR fixes the problem reported in At the top left of the help browser, the image hides the S of SuperCollider. #6138.
    • The reported problem:
      Screenshot 2024-04-28 at 14 49 11
    • Fixed with this PR:
      Screenshot 2024-04-28 at 14 50 37

I do not think my fix is the only way. I can remove it from this PR if @scztt fixes it, because I think this problem is definitely due to @scztt's fix as described in #6138 (comment).

  1. This PR also removes an unnecessary */ on line 691 in scdoc.css:
    margin-right: 0px;*/

Types of changes

  • Documentation
  • Bug fix

To-do list

  • Code is tested
  • All tests are passing
  • Updated documentation
  • This PR is ready for review

… 2. a typo correction in scdoc.css

- Resolve conflict between SC cube and text in SC Help Home
- a typo correction: remove an unnecessary */ on line 691.
@prko prko changed the title Rresolve the conflict between SC-cube and text in the SC help Home with a typo correction in scdoc.css Resolve the conflict between SC-cube and text in the SC help Home with a typo correction in scdoc.css Apr 30, 2024
@JordanHendersonMusic JordanHendersonMusic added the comp: SCDoc scdoc syntax, parser, and renderer. for changes to schelp files, use "comp: help" label May 7, 2024
Copy link
Contributor

@capital-G capital-G left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix!

Interestingly enough, this seems to have been introduced only recently, as 3.13 docs do not have it, but dev docs have it.

The only change on the docs I found which could have introduced this is 39702ec

So maybe it would be better to adjust the selectors so they work properly again? This would be closest to "just keep things as they are", which I think is the intention here.

Also using whitespaces to adjust placement is not considered the best kind of CSS styling :)

edit:

I think adding the following code would fix it - can you verify it @prko ?

li.menuitem a.menu-link.home {
    padding-left: 2.5em;
}

@prko
Copy link
Contributor Author

prko commented May 29, 2024

@capital-G

li.menuitem a.menu-link.home {
    padding-left: 2.5em;
}

Adding this block of code will fix the problem, so there is no need to change scdoc.js.
However, the sccube image should still be resized.

Your suggestion is better than my PR!
If you want to fix it, I can close it. It is not a problem!
Let me know what to do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: SCDoc scdoc syntax, parser, and renderer. for changes to schelp files, use "comp: help"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants