Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change localhost to hostname in docker-compose.yml #23300

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

leftmove
Copy link

@leftmove leftmove commented Apr 26, 2024

I have read the CONTRIBUTING.md file.

YES

What kind of change does this PR introduce?

Bug fix.

What is the current behavior?

Node 17+ binding to ipv6 by default, and the health check lists unhealthy when checking the hostname because localhost is not always the default.

What is the new behavior?

Environment variable used so the correct hostname is always used.

Additional context

Fix from this issue: #22867

@leftmove leftmove requested a review from a team as a code owner April 26, 2024 16:05
Copy link

vercel bot commented Apr 26, 2024

@leftmove is attempting to deploy a commit to the Supabase Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@tranhoangvuit tranhoangvuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants