Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/add compute badge - ON HOLD #23234

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Conversation

MildTomato
Copy link
Contributor

@MildTomato MildTomato commented Apr 24, 2024

I have read the CONTRIBUTING.md file.

YES

What kind of change does this PR introduce?

To increase awareness of what compute size a project is on

  • Adds badge with compute size
    • project card
    • homepage, next to project name
  • Also added HoverCard to show details and CTA to upgrade (if below 16XL)
  • UI pattern added for compute badge, used in www pricing page
  • Used Badge also in settings page

What is the current behavior?

Please link any relevant issues here.

What is the new behavior?

Feel free to include screenshots if it includes visual changes.

Additional context

Screenshot 2024-04-25 at 12 44 26 AM Screenshot 2024-04-25 at 12 44 23 AM Screenshot 2024-04-25 at 12 44 08 AM Screenshot 2024-04-25 at 12 44 58 AM With other icons in card Screenshot 2024-04-25 at 12 46 17 AM In add on settings page Screenshot 2024-04-25 at 1 51 11 AM

Add any other context or screenshots.

@MildTomato MildTomato requested review from a team as code owners April 24, 2024 16:43
Copy link

supabase bot commented Apr 24, 2024

No changes detected in supabase directory.
This pull request has been ignored for the connected project xguihxuzqibwxjnimxev due to its connection settings.
Go to Project Integrations Settings ↗︎ in order to change this behavior.


Branching Preview Branches by Supabase.
Learn more about Supabase for Git ↗︎.

Copy link

vercel bot commented Apr 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
database-new 🔄 Building (Inspect) Visit Preview Apr 24, 2024 6:07pm
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2024 6:07pm
studio-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2024 6:07pm
zone-www-dot-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2024 6:07pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
studio ⬜️ Ignored (Inspect) Visit Preview Apr 24, 2024 6:07pm
studio-self-hosted ⬜️ Ignored (Inspect) Visit Preview Apr 24, 2024 6:07pm
ui-storybook ⬜️ Ignored (Inspect) Apr 24, 2024 6:07pm

Copy link

<p>
{computeInstance?.variant.name ??
<div className="flex py-3">
{/* {computeInstance?.variant.name ??
capitalize(selectedProject?.infra_compute_size) ??
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't need?

@MildTomato
Copy link
Contributor Author

On hold - We are waiting for some migrations to finish in infra

@MildTomato MildTomato marked this pull request as draft April 25, 2024 03:57
@MildTomato MildTomato changed the title Chore/add compute badge Chore/add compute badge - ON HOLD Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants