Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(postgrest): Update parameter type of isFilter() to only allow boolean or null #920

Merged
merged 1 commit into from May 13, 2024

Conversation

dshukertjr
Copy link
Member

What kind of change does this PR introduce?

Fixes #917

What is the current behavior?

Currently any object can be passed as the value parameter of isFilter()

What is the new behavior?

Only null and boolean values can be passed to isFilter()

@dshukertjr dshukertjr requested review from DanMossa, bdlukaa and Vinzent03 and removed request for DanMossa, bdlukaa and Vinzent03 May 8, 2024 13:44
Copy link
Collaborator

@Vinzent03 Vinzent03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same breaking change warning as in #919 Just to note for the future.

@dshukertjr dshukertjr merged commit 0a3b73e into main May 13, 2024
9 checks passed
@dshukertjr dshukertjr deleted the fix/isFilter branch May 13, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Matching on null fails to return anything
2 participants