fix: gotrue config persistence for AIO #961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
pcnc
commented
May 1, 2024
pcnc
commented
- Fixes GoTrue losing its config on subsequent restarts
- Replaces gotrue's and fail2ban's commands to ensure external processes don't restart the service's process itself
- Adds flag to disable pgbouncer
tomashley
reviewed
May 1, 2024
docker/all-in-one/entrypoint.sh
Outdated
| @@ -80,10 +80,23 @@ function enable_lsn_checkpoint_push { | |||
| } | |||
|
|
|||
| function disable_fail2ban { | |||
| sed -i "s/command=.*/command=sleep 1/" /etc/supervisor/services/fail2ban.conf | |||
There was a problem hiding this comment.
there is a danger here that this sleep isn't long enough.
By default if a program doesn't stay up for 1 second, it is considered a failure and it will restart
I would set this to 2, or set startsecs to 0 - but startsecs isn't in the config file rn
from the manual
startsecs
The total number of seconds which the program needs to stay running after a startup to consider the start successful (moving the process from the STARTING state to the RUNNING state). Set to 0 to indicate that the program needn’t stay running for any particular amount of time.
Note
Even if a process exits with an “expected” exit code (see exitcodes), the start will still be considered a failure if the process exits quicker than startsecs.
Default: 1
Required: No.
Introduced: 3.0
There was a problem hiding this comment.
Ooh, nice catch. Will set it to 5 just to make sure it doesn't have any side effects
pcnc
changed the title
tomashley
approved these changes
May 1, 2024
|
may need to update testinfra tests |
pashkinelfe
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.