chore: add suggestions for testing extension changes #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcnc
approved these changes
Jun 1, 2023
egor-romanov
reviewed
Jun 1, 2023
egor-romanov
reviewed
Jun 1, 2023
| - [ ] backup/restore on a project with the extension enabled | ||
| - [ ] backup/restore on a project, after the extension has been enabled and then disabled | ||
| - [ ] backup from an old project (w/o change), restore to a new project (w/ change) | ||
| - [ ] backup from older project (e.g. early 13/14/15 build), restore to a new project (w/ change) |
There was a problem hiding this comment.
should we also backup and restore with all/the majority of other extensions enabled as well as the new/updated one?
There was a problem hiding this comment.
Have we seen any such failure cases? At the limit you'll end up testing all combinations of extensions, which isn't very feasible.
There was a problem hiding this comment.
i would just suggest all.
yep, i think there were some conflicts when we initially tried adding vault
There was a problem hiding this comment.
all or just top 20, we had csv in slack with usage stats
|
would be great addition to PR template in this repo, also, but i am not sure if youd like it there too Like this one https://github.com/supabase/.github/blob/main/PULL_REQUEST_TEMPLATE.md |
egor-romanov
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.