fix: improve abuse message, don't log request #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J0
approved these changes
Oct 25, 2022
kangmingtay
requested changes
Oct 25, 2022
| @@ -319,7 +319,7 @@ func (a *API) RefreshTokenGrant(ctx context.Context, w http.ResponseWriter, r *h | |||
| return internalServerError(err.Error()) | |||
| } | |||
| } | |||
| return oauthError("invalid_grant", "Invalid Refresh Token").WithInternalMessage("Possible abuse attempt: %v", r) | |||
| return oauthError("invalid_grant", "Invalid Refresh Token").WithInternalMessage("Possible abuse attempt with refresh tokens. Often this is caused by a buggy implementation of Server-Side Rendering.") | |||
There was a problem hiding this comment.
Suggested change
| return oauthError("invalid_grant", "Invalid Refresh Token").WithInternalMessage("Possible abuse attempt with refresh tokens. Often this is caused by a buggy implementation of Server-Side Rendering.") | |
| return oauthError("invalid_grant", "Invalid Refresh Token").WithInternalMessage("Possible abuse attempt, refresh token was reused: %v", token) |
| @@ -422,7 +422,7 @@ func (a *API) IdTokenGrant(ctx context.Context, w http.ResponseWriter, r *http.R | |||
| // verify nonce to mitigate replay attacks | |||
| hash := fmt.Sprintf("%x", sha256.Sum256([]byte(params.Nonce))) | |||
| if hash != hashedNonce.(string) { | |||
| return oauthError("invalid nonce", "").WithInternalMessage("Possible abuse attempt: %v", r) | |||
| return oauthError("invalid nonce", "").WithInternalMessage("Possible abuse attempt with refresh tokens. Often this is caused by a buggy implementation of Server-Side Rendering.") | |||
There was a problem hiding this comment.
Suggested change
| return oauthError("invalid nonce", "").WithInternalMessage("Possible abuse attempt with refresh tokens. Often this is caused by a buggy implementation of Server-Side Rendering.") | |
| return oauthError("invalid nonce", "").WithInternalMessage("Possible abuse attempt, nonce does not match the nonce in the id token.") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logging the request may leak some dangerous information such as the
Authorizationheader. Adds clarification about the common cause for this error.