Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add additional information around errors for missing content type header #1576

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

J0
Copy link
Contributor

@J0 J0 commented May 8, 2024

What kind of change does this PR introduce?

Adds additional information around errors related to missing content-type headers so that developers can unblock themselves.

Need to decide whether to place the check behind 200 responses as developers can forget to add content-type headers to 500 responses.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8997738253

Details

  • 8 of 12 (66.67%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.005%) to 65.467%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/api/hooks.go 8 12 66.67%
Totals Coverage Status
Change from base Build 8997004849: -0.005%
Covered Lines: 8368
Relevant Lines: 12782

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants