feat: remove legacy lookup in users for one_time_tokens (phase II) #1569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hf
force-pushed
the
hf/phase-ii-ott
branch
3 times, most recently
from
8b185b5
to
9c90f81
Compare
kangmingtay
force-pushed
the
hf/phase-ii-ott
branch
from
7c9eb30
to
9b31ffa
Compare
kangmingtay
force-pushed
the
hf/phase-ii-ott
branch
from
9b31ffa
to
109d51f
Compare
kangmingtay
approved these changes
May 8, 2024
kangmingtay
force-pushed
the
hf/phase-ii-ott
branch
from
d3ab475
to
9546cd8
Compare
kangmingtay
force-pushed
the
hf/phase-ii-ott
branch
from
9546cd8
to
55393c4
Compare
Pull Request Test Coverage Report for Build 9115947616Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
J0
approved these changes
May 8, 2024
J0
pushed a commit
that referenced
this pull request
May 22, 2024
🤖 I have created a release *beep* *boop* --- ## [2.152.0](v2.151.0...v2.152.0) (2024-05-22) ### Features * new timeout writer implementation ([#1584](#1584)) ([72614a1](72614a1)) * remove legacy lookup in users for one_time_tokens (phase II) ([#1569](#1569)) ([39ca026](39ca026)) * update chi version ([#1581](#1581)) ([c64ae3d](c64ae3d)) * update openapi spec with identity and is_anonymous fields ([#1573](#1573)) ([86a79df](86a79df)) ### Bug Fixes * improve logging structure ([#1583](#1583)) ([c22fc15](c22fc15)) * sms verify should update is_anonymous field ([#1580](#1580)) ([e5f98cb](e5f98cb)) * use api_external_url domain as localname ([#1575](#1575)) ([ed2b490](ed2b490)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes legacy lookups in
auth.usersfor when a corresponding entry inone_time_tokensis not found.Phase II of the refactor, based on #1558, to be released after it's deployed for a few days.