New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow aliases on local development #1524
base: master
Are you sure you want to change the base?
Conversation
Pull Request Test Coverage Report for Build 8623798274Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why don't we make the hostname an internal config option which we can set? makes it easier to update as well
@@ -505,7 +505,7 @@ func (e *ExtensibilityPointConfiguration) ValidateExtensibilityPoint() error { | |||
return validatePostgresPath(u) | |||
case "http": | |||
hostname := u.Hostname() | |||
if hostname == "localhost" || hostname == "127.0.0.1" || hostname == "::1" || hostname == "host.docker.internal" { | |||
if hostname == "localhost" || hostname == "127.0.0.1" || hostname == "::1" || hostname == "host.docker.internal" || hostname == "kong" || hostname == "edge_runtime" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah let's make this a config option, and CLI can set these...
What kind of change does this PR introduce?
Allow developers to use aliases such as kong and edge_functions for local development as
host.docker.internal
might not be compatible on all platformsLink: supabase/cli#2129 (comment)