Feat: Add Naver To Provider #1251
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How to get client_id and client_secret can be found in the guide at the link. However, NAVER DEVELOPERS, where the guide page is located, does not support English. (I don't really understand why either,,,) On the following site, a blogger has recorded the process of using the NAVER Login API, which may be helpful. https://medium.com/@monsoonkhadka8/naver-login-api-interworking-php-in-english-df14b66c824e If you need it, you need to request an official guide in English from the site. |
|
Can we please merge this PR?
|
minyoon
reviewed
Nov 28, 2023
Comment on lines
+169
to
+184
| // func (ts *ExternalTestSuite) TestSignupExternalNaverErrorWhenVerifiedFalse() { | ||
| // tokenCount, userCount := 0, 0 | ||
| // code := "authcode" | ||
| // emails := `[{"email":"naver@example.com", "primary": true, "verified": false}]` | ||
| // server := NaverTestSignupSetup(ts, &tokenCount, &userCount, code, emails) | ||
| // defer server.Close() | ||
|
|
||
| // u := performAuthorization(ts, "naver", code, "") | ||
|
|
||
| // v, err := url.ParseQuery(u.Fragment) | ||
| // ts.Require().NoError(err) | ||
| // ts.Equal("unauthorized_client", v.Get("error")) | ||
| // ts.Equal("401", v.Get("error_code")) | ||
| // ts.Equal("Unverified email with naver", v.Get("error_description")) | ||
| // assertAuthorizationFailure(ts, u, "", "", "") | ||
| // } |
There was a problem hiding this comment.
Oops, I just commented it out.
I'll remove it.
|
is there any update on this? Korean's will be very happy if this PR is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Add Naver to external provider
What is the current behavior?
Nothing. It's a new feature.
What is the new behavior?
The users can select Naver as an external provider.
Additional context
Naver is a Google-like portal site that supports social login for most services in Korea.
Naver has just as many users in Korea as Kakao, so I was surprised that there was no feature request to add Naver as a provider in the issues.
If Naver is added as an external provider, Koreans, including me, will be very happy.