feat: use largest avatar from spotify instead #1210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kangmingtay
previously requested changes
Aug 7, 2023
There was a problem hiding this comment.
@william-matz thanks for contributing! i think we can leave the current setting as such and extend this by adding the entire image list returned by spotify to the provider's custom claims (https://github.com/supabase/gotrue/blob/4745451a931c2be5d36c07b37bd0eb3ab7780587/internal/api/provider/provider.go#L59)
hf
dismissed
kangmingtay’s stale review
I think this is fine. Most users want the largest avatar anyway.
hf
changed the title
|
@william-matz Please fix the failing checks before we can approve and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracts the largest avatar returned by Spotify, instead of the first avatar in the list.
Fixes: