feat: make the email client explicity set the format to be HTML #1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J0
reviewed
Jul 14, 2023
| mail.SetHeader("Message-ID", fmt.Sprintf("<%s@gotrue-mailer>", uuid.Must(uuid.NewV4()).String())) | ||
| mail.SetHeaders(map[string][]string{ | ||
| // Make the emails explicitly set to be HTML formatted (to cover older email clients) | ||
| "Content-Type": {"text/html; charset=utf-8"}, |
There was a problem hiding this comment.
Thanks for the contribution! There's an existing SetBody within the mailme package- https://github.com/supabase/mailme/blob/main/mailme.go#L71
Not sure if that will override the header. set here - if it doesn't then I think this should be good to go!
There was a problem hiding this comment.
It sets the body type there, but it doesn't make it clear in the header which confuses some old email clients.
They are different/ won't override one another.
|
Hmmm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This makes the emails to be explicitly set to be HTML formatted instead of plain text which helper older clients that cannot figure this out themselves.
What is the current behavior?
Email messages are sent as plain/text.
What is the new behavior?
Feel free to include screenshots if it includes visual changes.
Additional context
Add any other context or screenshots.