Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix-total_variation_kernel_bug #63

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

guanjunwu
Copy link

@guanjunwu guanjunwu commented May 15, 2023

Thank for the nice work ! In function of __global__ void total_variation_add_grad_cuda_kernel in the file total_variation_kenel.cu, I found that there may be a problem in add grad.
when reading the paper, I think that this function means to deal with the Aliasing in the voxel grid and let the voxel grid's value become more smooth.Therefore, if in 3D voxel grid ,the method of add variation in voxel grid maybe is to add grad in axis x,y,z. But I found that axis z was reused, so I change it to 'wx' in gradient axis 'x'.
I also run the experiment between the changes ,I found that the PSNR will raise by 0.02 in llff dataset ,Scene room.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant