The reason that sunkit-image exists #200
Open
+17
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpshelio
approved these changes
May 27, 2024
Cadair
reviewed
Jun 4, 2024
| The goal of the ``sunkit-image`` library is to provide access to image processing routines that are: | ||
|
|
||
| 1. Focused on being applied to solar physics data. | ||
| 2. Are published in the literature. |
There was a problem hiding this comment.
What about that are in-prep? I like the idea of people writing their algorithms in sunkit-image before they publish so they can say that's where it will be in the paper? Or does this open us up to "oh we are going to publish this eventually"?
There was a problem hiding this comment.
How about if they can prove its in prep?
Cadair
reviewed
Jun 4, 2024
|
|
||
| 1. Focused on being applied to solar physics data. | ||
| 2. Are published in the literature. | ||
| 3. If there is no publication, it must be widely used or perceived as generally useful throughout the solar physics community. |
There was a problem hiding this comment.
I see the reason for this but it's a bit wolly? 🐑
There was a problem hiding this comment.
Yes this is very wolly, deliberately so.
Mind, I did not have a specific use case in mind when I wrote this but I did want an out but that does leave us open to a "debate" about a code.
nabobalis
commented
Jun 4, 2024
| The goal of the ``sunkit-image`` library is to provide access to image processing routines that are: | ||
|
|
||
| 1. Focused on being applied to solar physics data. | ||
| 2. Are published in the literature. |
There was a problem hiding this comment.
Suggested change
| 2. Are published in the literature. | |
| 2. Are published in the literature or in preparation to be published. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #190