Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a section to the docs about which algorithms we accept #190

Open
wtbarnes opened this issue Mar 20, 2024 · 0 comments · May be fixed by #200
Open

Add a section to the docs about which algorithms we accept #190

wtbarnes opened this issue Mar 20, 2024 · 0 comments · May be fixed by #200

Comments

@wtbarnes
Copy link
Member

wtbarnes commented Mar 20, 2024

In the past, we've accepted more or less any algorithm into sunkit-image. This has worked fine as we've not had an abundance of potential contributors and thus haven't had to turn any away. However, as more potential contributions come in, this may increasingly become a problem.

In general, we should come up with a policy for what kind of algorithms we accept and which we don't. In general, I would recommend that we only accept algorithms with an accompanying publication and/or ones that are widely used or perceived as generally useful throughout the solar physics community.

Additionally, we should think about to what extent we own that algorithm. In the past, we've ingested all of the code into sunkit-image, but there's also a strong case for just providing a wrapper that exposes a consistent interface (e.g. #188).

We need to agree on what our policy is regarding the above points and then document them in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants