Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat:Supports editing of predefined prompts. If the title is the same… #454

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

qcgm1978
Copy link
Contributor

… after editing, it will replace the original prompt. Otherwise, it will create a new prompt.

截屏2023-07-22 20 29 41

… after editing, it will replace the original prompt. Otherwise, it will create a new prompt.
@vercel
Copy link

vercel bot commented Jul 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chatall ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 22, 2023 0:31am

@sunner
Copy link
Owner

sunner commented Jul 22, 2023

@tanchekwei Could you give a review? I believe you must have some reason to prevent editing the predefined prompts.

@tanchekwei
Copy link
Contributor

@tanchekwei Could you give a review? I believe you must have some reason to prevent editing the predefined prompts.

Added comment.

If a user wants to edit a predefined prompt, currently they can pin a prompt (which will add it to local storage) and then edit it.

@tanchekwei
Copy link
Contributor

@sunner, do you think we need to add another button, Duplicate button, for users to duplicate a predefined prompt and let them click the Edit button to modify it? Or, should we go with @qcgm1978’s approach and simply use the current Edit button for both duplicate and edit actions?

If we choose to add a Duplicate button, users will need to click two buttons to edit a predefined prompt: first, they click the Duplicate button, and then they click the Edit button. This approach is clearer.

if we use the Edit button for both actions, users will only need to click it once to edit the prompt. However, the existing edit button already use to edit the current user's prompt, same button with different behaviors may lead to confusion. What do you think?

@sunner
Copy link
Owner

sunner commented Jul 23, 2023

Frankly speaking, I prefer an empty customized prompt library. The owner can choose to insert/edit/delete prompts, and import bulk prompts from other sources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants