Formatter, Linter and fixes #62
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alpe
commented
Jan 19, 2024
alpe
commented
Jan 19, 2024
alpe
commented
Jan 19, 2024
alpe
commented
Jan 19, 2024
nstogner
reviewed
Jan 21, 2024
nstogner
reviewed
Jan 21, 2024
samos123
reviewed
Feb 6, 2024
nstogner
requested changes
Feb 6, 2024
.golangci.yaml
Outdated
|
|
||
| linters: | ||
| disable-all: true | ||
| enable: |
There was a problem hiding this comment.
I would prefer to take a minimal approach to linting here. IMO too many linters leads to an annoying development experience and excessive comments to appease all of the linters. Can we stick to the official go toolchain?
There was a problem hiding this comment.
If there is a tool that should absolutely be added in excess of the standard toolchain, can we add a comment as to why it is needed and is not redundant?
|
I have removed the linter config and integration to move this forward. Personally, I have seen a lot of benefits in linters in addition to the Go toolchain but I am definitively not dogmatic about it. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #49
Fixes issues found by a gosec run