You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove deprecated react explorer (client directory)
As we have ported this project to NextJS and moved it to the explorer directory, this PR deletes the old client directory and fixes workflows that were using this directory.
PR Type
enhancement
Description
Removed the entire client directory as the project has transitioned to NextJS and moved to the explorer directory.
Updated GitHub Actions build workflow to adjust the working directory from client to explorer.
Removed deployment workflow as deployment is now handled via Netlify hooks.
Added a root .gitignore to ignore .DS_Store files.
Changes walkthrough 📝
Relevant files
Configuration changes
build.yaml
Update build workflow to use new explorer directory
.github/workflows/build.yaml
Updated the workflow to change the working directory from client to explorer.
2, because the PR mainly involves deletion of files and a simple update in the workflow configuration. The changes are straightforward and do not involve complex logic or new functionality.
🧪 Relevant tests
No
⚡ Possible issues
No
🔒 Security concerns
No
Code feedback:
relevant file
.github/workflows/build.yaml
suggestion
Ensure that all dependencies and scripts in the 'explorer' directory are correctly configured to replace the 'client' directory. This includes checking package.json, any build scripts, and ensuring all paths in the workflow are correctly updated. [important]
Consider adding a step in the GitHub Actions workflow to verify that the transition from 'client' to 'explorer' does not break any existing functionality. This could be a script that checks for critical files or runs a small suite of integration tests. [important]
Since the 'client' directory is removed, ensure that any references to environment variables or paths specific to the 'client' setup are also updated or removed in the GitHub Actions environment settings. [medium]
Verify that all necessary caching mechanisms (e.g., node_modules) are correctly configured for the 'explorer' directory in the GitHub Actions workflow to optimize build times. [medium]
Review and justify the inclusion of lastBlock in the dependency array.
Ensure that the lastBlock variable is used within the component or remove it from the dependency array if it's not affecting the rendering or logic. Unused dependencies in the array can lead to unnecessary re-renders or confusion about the component's reactive properties.
-}, [+}, [ // Assuming `lastBlock` is now used or removed based on its necessity
actingAccount,
action,
- lastBlock,
excludeActions,
handleAction,
nominatorMaxStake,
Enhancement
Correct the job name in the GitHub Actions workflow to match the intended directory.
Update the job name from ts-lint-and-build-explorer to ts-lint-and-build-client to reflect the correct directory and purpose, especially if the client directory is still relevant. This helps maintain clarity in CI/CD pipeline configurations.
Verify and update external dependencies and references due to the removal of the client directory.
Since the client directory is being removed, ensure that any references or dependencies in other projects or configurations that rely on the client directory are updated or removed to prevent broken links or errors.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
marc-aurele-besner
dismissed
jfrank-summit’s stale review
User description
Remove deprecated react explorer (client directory)
As we have ported this project to NextJS and moved it to the explorer directory, this PR deletes the old client directory and fixes workflows that were using this directory.
PR Type
enhancement
Description
clientdirectory as the project has transitioned to NextJS and moved to theexplorerdirectory.clienttoexplorer..gitignoreto ignore.DS_Storefiles.Changes walkthrough 📝
build.yaml
Update build workflow to use new explorer directory.github/workflows/build.yaml
clienttoexplorer.