Add GitHub provider

[marc-aurele-besner]

User description

Add GitHub provider

---

Type

enhancement

---

Description

• Added GitHub authentication support across various components and utilities.
• Defined and utilized GitHubToken type for handling GitHub data.
• Implemented GitHubFlow component for GitHub account connection.
• Updated authentication providers to include GitHub, enhancing the system's integration capabilities.

---

Changes walkthrough

	Relevant files
Enhancement	6 files next-auth.d.ts Integrate GitHubToken into User Interface Definitions        explorer/next-auth.d.ts Added GitHubToken type to the User interface in various contexts. +4/-0      GetDiscordRoles.tsx Add GitHub Account Connection Component                                    explorer/src/components/WalletSideKick/GetDiscordRoles.tsx Added a new component GitHubFlow to handle GitHub account connection. Integrated GitHubFlow into the existing list components. +28/-0    jwt.ts Define GitHubToken Type                                                                    explorer/src/types/jwt.ts Defined a new TypeScript type GitHubToken. +5/-0      discord.ts Enhance Discord Auth to Include GitHub Token                          explorer/src/utils/auth/providers/discord.ts Ensured GitHub token is included or defaults are used in the Discord provider. +2/-0      github.ts Implement GitHub Authentication Provider                                  explorer/src/utils/auth/providers/github.ts Implemented a new GitHub authentication provider. +46/-0    subspace.ts Update Subspace Auth Provider to Handle GitHub Token          explorer/src/utils/auth/providers/subspace.ts Included default GitHub token handling in the Subspace provider. +2/-1
Configuration changes	3 files session.ts Define Default GitHub Token Constant                                          explorer/src/constants/session.ts Added a new constant DEFAULT_GITHUB_TOKEN. +6/-1      authOptions.ts Update Authentication Options to Include GitHub                    explorer/src/utils/auth/authOptions.ts Included github in the token configuration for session management. +1/-0      index.ts Register GitHub as an Authentication Provider                        explorer/src/utils/auth/providers/index.ts Added GitHub to the list of authentication providers. +2/-1

---

✨ PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

[github-actions]

PR Description updated to latest commit (8babcd9)

[github-actions]

PR Review

⏱️ Estimated effort to review [1-5]	3, because the PR involves multiple files and integrates a new authentication provider which requires careful consideration of security and proper integration with existing systems.
🧪 Relevant tests	No
🔍 Possible issues	Possible Bug: The error message in explorer/src/utils/auth/providers/github.ts mentions "Error fetching Discord profile" instead of "Error fetching GitHub profile". This could lead to confusion during debugging.
🔒 Security concerns	No

Code feedback:

---

relevant file	explorer/src/utils/auth/providers/github.ts
suggestion	Consider adding error handling for missing environment variables GITHUB_CLIENT_ID and GITHUB_CLIENT_SECRET before they are used. This can prevent runtime errors in environments where these variables are not set. [important]
relevant line	clientId: GITHUB_CLIENT_ID || '',

---

relevant file	explorer/src/utils/auth/providers/github.ts
suggestion	Update the error message to correctly reflect the GitHub context instead of Discord to avoid confusion during error handling. [important]
relevant line	console.error('Error fetching Discord profile:', error)

---

relevant file	explorer/src/utils/auth/providers/github.ts
suggestion	Ensure that the session token is securely handled and consider using HttpOnly cookies to prevent access from client-side scripts. This enhances security by mitigating the risk of XSS attacks. [important]
relevant line	const sessionToken = get('next-auth.session-token')?.value || ''

---

relevant file	explorer/src/utils/auth/providers/github.ts
suggestion	Validate the profile.id and profile.login from the GitHub profile to ensure they are not null or undefined before using them to construct the user object. This prevents potential runtime errors. [medium]
relevant line	id: profile.id,

---

---

✨ Review tool usage guide:

---

Overview:
The review tool scans the PR code changes, and generates a PR review which includes several types of feedbacks, such as possible PR issues, security threats and relevant test in the PR. More feedbacks can be added by configuring the tool.

The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.

• When commenting, to edit configurations related to the review tool (pr_reviewer section), use the following template:

/review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=...

• With a configuration file, use the following template:

[pr_reviewer]
some_config1=...
some_config2=...

See the review usage page for a comprehensive guide on using this tool.

[github-actions]

PR Code Suggestions

Category	Suggestions
Enhancement	Improve button label clarity for GitHub connection. Consider using a more descriptive button label than 'Refresh' for the GitHub connection button when the user is already a member. This could improve user experience by making the button's purpose clearer. explorer/src/components/WalletSideKick/GetDiscordRoles.tsx [118-120] <StyledButton className='ml-2' onClick={handleConnectGitHub}> - Refresh + Refresh GitHub Connection </StyledButton>
Bug	Correct the error message to accurately reflect the GitHub profile fetching operation. Replace the generic error message 'Failed to fetch Discord profile' with a more appropriate message reflecting the actual operation, such as 'Failed to fetch GitHub profile'. explorer/src/utils/auth/providers/github.ts [42] -throw new Error('Failed to fetch Discord profile') +throw new Error('Failed to fetch GitHub profile')
	Update error logging to reflect the correct service (GitHub) in error messages. Avoid using the generic error message 'Error fetching Discord profile:' in the GitHub provider and replace it with a more specific message for GitHub. explorer/src/utils/auth/providers/github.ts [41] -console.error('Error fetching Discord profile:', error) +console.error('Error fetching GitHub profile:', error)
Security	Add error handling for missing GitHub client credentials. Ensure that the GitHub client ID and secret are not empty by adding checks and handling cases where they might be undefined or empty, to prevent runtime errors during authentication. explorer/src/utils/auth/providers/github.ts [12-13] -clientId: GITHUB_CLIENT_ID || '', -clientSecret: GITHUB_CLIENT_SECRET || '', +clientId: GITHUB_CLIENT_ID || throw new Error('GitHub client ID is required'), +clientSecret: GITHUB_CLIENT_SECRET || throw new Error('GitHub client secret is required'),
Robustness	Add checks for essential GitHub profile fields to prevent runtime errors. Consider adding a check to ensure that the GitHub profile object contains the required fields (id and login) before attempting to use them, to prevent potential runtime errors. explorer/src/utils/auth/providers/github.ts [36-37] -id: profile.id, -username: profile.login, +id: profile.id || throw new Error('GitHub profile ID is missing'), +username: profile.login || throw new Error('GitHub profile username is missing'),

---

✨ Improve tool usage guide:

---

Overview:
The improve tool scans the PR code changes, and automatically generates suggestions for improving the PR code. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on a PR.

• When commenting, to edit configurations related to the improve tool (pr_code_suggestions section), use the following template:

/improve --pr_code_suggestions.some_config1=... --pr_code_suggestions.some_config2=...

• With a configuration file, use the following template:

[pr_code_suggestions]
some_config1=...
some_config2=...

See the improve usage page for a comprehensive guide on using this tool.